This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Conversation
prymitive
force-pushed
the
viper
branch
2 times, most recently
from
2a6ca03 to
3b4f498
Compare
This adds support for reading configuration from file, env support is still there and legacy env variables will still work, but flags are now following config schema, so they don't match old flags. Having a config file allows to express more complex configuration options, which is needed for some feature requests.
prymitive
force-pushed
the
viper
branch
2 times, most recently
from
f578685 to
f1f0ccc
Compare
… to match new config file.
there's --labels.keep so same should apply to receivers, add new option, tests and fixes as it wasn't working properly
Contributor
Author
|
Now complete and ready for review |
Only HOST & PORT env variables used by gin internally were really used, pass resulting config to gin so we match documentation, and log it on startup
Contributor
Author
|
Added more docs & tests, and corrected few bugs found while doing that |
bobrik
approved these changes
Dec 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow fixing #182, once there's a config file I can add more config keys for each Alertmanager server definition.