This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Add REMOVE_RECEIVERS option#196
Merged
prymitive merged 1 commit intocloudflare:masterfrom Nov 24, 2017
Merged
Conversation
prymitive
suggested changes
Nov 24, 2017
Contributor
prymitive
left a comment
prymitive
left a comment
There was a problem hiding this comment.
Any new options should be documented under README.md#environment-variables (sorted alphabetically)
internal/config/config.go
Outdated
| FilterDefault string `envconfig:"FILTER_DEFAULT" help:"Default filter string"` | ||
| JiraRegexp spaceSeparatedList `envconfig:"JIRA_REGEX" help:"List of JIRA regex rules"` | ||
| Port int `envconfig:"PORT" default:"8080" help:"HTTP port to listen on"` | ||
| RemoveReceivers spaceSeparatedList `envconfig:"REMOVE_RECEIVERS" help:"List of receivers to not display alerts for"` |
Contributor
There was a problem hiding this comment.
How about IGNORED_RECEIVERS instead of REMOVE_RECEIVERS?
Or maybe STRIP_RECEIVERS since there's already STRIP_LABELS
This option allows for all alerts for a specified receiver, or list of receivers, to be removed from unsee. My use case for this is using a receiver for auto-remediation which will contain information that the user will never need to see in the UI.
luke-orden
force-pushed
the
add_REMOVE_RECEIVERS
branch
from
662cae9 to
f8c327c
Compare
prymitive
approved these changes
Nov 24, 2017
|
In the future, you probably want to have the commit message describe the actual option added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option allows for all alerts for a specified receiver, or list of
receivers, to be removed from unsee.
My use case for this is using a receiver for auto-remediation which will
contain information that the user will never need to see in the UI.