This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Merged
Conversation
terinjokes
reviewed
Nov 7, 2017
| FROM golang:1.9.2-alpine3.6 as unsee-builder | ||
| COPY . /go/src/github.com/cloudflare/unsee | ||
|
|
||
| ARG VERSION |
There was a problem hiding this comment.
nit: it might be better to use a nodejs image here, rather than installing Node.js into a Go build image.
Contributor
Author
There was a problem hiding this comment.
but then I need to install go into nodejs image
Contributor
Author
There was a problem hiding this comment.
That would be unrelated to version bumps here, feel free to open a ticket for that
prymitive
force-pushed
the
npm-updates
branch
from
c525ba4 to
87d2feb
Compare
terinjokes
approved these changes
Nov 20, 2017
prymitive
force-pushed
the
npm-updates
branch
from
87d2feb to
6918b78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.