This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Conversation
terinjokes
suggested changes
Aug 23, 2017
| </script> | ||
|
|
||
| <script type="application/json" id="alert-annotation"> | ||
| <% var cls = "" %> |
There was a problem hiding this comment.
Why not use the <details> and <summary> elements?
<details open>
<summary>Summary</summary>
<p>Lorem Ipsum is simply dummy text of the printing and typesetting industry.</p>
</details>
Contributor
Author
There was a problem hiding this comment.
cls is used to set hidden hidden-annotation if needed, not sure how <details> and <summary> relates to that
|
|
||
| This variable is required and there is no default value. | ||
|
|
||
| #### ANNOTATIONS_DEFAULT_HIDDEN |
There was a problem hiding this comment.
Wouldn't it make more sense for these to be user-specific options configured in the UI?
Contributor
Author
There was a problem hiding this comment.
Probably, but that would be an ugly UI if I dump it under current settings menu, so I'm not even going to try right now.
terinjokes
approved these changes
Sep 7, 2017
Annotations are just string maps, but to render those we need a bit more information (is it a link, should it be visible by default). Store them as more complex structs internally, this also allows us to drop alert.Links since we now have enough information to tell if annotation is a link
If user make annotation hidden by default, then render a button that allows to show it per label
This allows to signal to the UI which annotations to hide and which to show by default, user still can view hidden ones
Alert group needs more space after expanding, so we need to redraw everything.
prymitive
force-pushed
the
hide-annotations
branch
from
c914483 to
5d0366a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
READMEchanges for details.Fixes #169