This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Merged
Conversation
terinjokes
reviewed
Aug 8, 2017
README.md
Outdated
|
|
||
| make | ||
|
|
||
| Note that building locally from sources requires Go and nodejs & npm. |
Contributor
Author
There was a problem hiding this comment.
I always considered nodejs & npm inseparable
terinjokes
suggested changes
Aug 8, 2017
| -ldflags "-X main.version=${VERSION:-dev}" \ | ||
| github.com/cloudflare/unsee && \ | ||
| rm -fr /go/src | ||
| RUN apk add --update make git nodejs |
There was a problem hiding this comment.
Either run this as one line (to avoid extra layers), or use Docker's multi-stage builds
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
best tip ever
unsee v0.7.2-108-g1342f04-dev 4c658f9c12da 4 seconds ago 276MB
unsee v0.7.2-106-ga181807-dev 93f70b5d62a5 22 minutes ago 947MB
terinjokes
suggested changes
Aug 9, 2017
Dockerfile
Outdated
| @@ -1,14 +1,10 @@ | |||
| FROM golang:1.8.3-alpine | |||
There was a problem hiding this comment.
FROM golang:1.8.3-alpine as unsee-builderThen use --from=unsee-builder down below.
By dropping vendor & bindata.go from git unsee is no longer go installable, and realistically it won't be, because the build pipeline is big and involves multiple tools. Let's just use make targets we use for development when building docker image.
terinjokes
approved these changes
Aug 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.