Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Comments

Fix autocomplete dropdown selection color#157

Merged
prymitive merged 1 commit intomasterfrom
fix-ac-ccs
Aug 11, 2017
Merged

Fix autocomplete dropdown selection color#157
prymitive merged 1 commit intomasterfrom
fix-ac-ccs

Conversation

@prymitive
Copy link
Contributor

@prymitive prymitive commented Aug 5, 2017

Selector is too wide and doesn't action, add div to make it work again.

@prymitive prymitive added the bug label Aug 5, 2017
@prymitive prymitive requested review from Tenzer and jamesog August 5, 2017 20:19
@terinjokes
Copy link

What does this change have to do with the selection color?

@prymitive
Copy link
Contributor Author

Those selectors have styling changes applied for autocomplete dropdown, making it look like the rest of bootstrap flatly themed elements. There's no less or scss in https://github.com/bootstrap-tagsinput/bootstrap-tagsinput/tree/master/src that could read of flatly variables file.

@prymitive
Copy link
Contributor Author

Classes are controlled by typeahead, not by tagsinpt, so I need to follow https://github.com/corejavascript/typeahead.js/blob/master/doc/jquery_typeahead.md#class-names and configure proper classes here.

We use flatly theme for bootstrap while bootstrap-tagsinput bundles a css file that follow vanilla style, create a less version and use it instead of the css one bundles with bootstrap-tagsinput.
typeahead.js allows to customize class names used for UI elements, but bootstrap-tagsinput doesn't support passing that and is no longer maintained, so we need to follow default typeahead.js classes.
@prymitive
Copy link
Contributor Author

Reworked to use a less style file that imports from bootstrap, see commit for details.

@prymitive prymitive requested a review from terinjokes August 11, 2017 17:50
@prymitive prymitive merged commit 067bd2e into master Aug 11, 2017
@prymitive prymitive deleted the fix-ac-ccs branch August 11, 2017 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants