Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Comments

Jest & webpack#150

Merged
prymitive merged 79 commits intomasterfrom
jest
Aug 4, 2017
Merged

Jest & webpack#150
prymitive merged 79 commits intomasterfrom
jest

Conversation

@prymitive
Copy link
Contributor

@prymitive prymitive commented Jul 30, 2017

This PR:

  • rewrites all JS files as CommonJS modules (no real code changes)
  • adds jest tests so we finally have a framework & most basic test coverage for JS files
  • adds webpack so all JS files are vendored and managed via npm (needed since browsers can't load CommonJS modules yet)

Benefits:

  • tests for JS
  • proper asset management for JS/CSS (no more curl cdnjs from a Makefile)
  • webpack allows to transform ES6 modules to ES5 on the fly, so no more issues like "Internal error TypeError Alerts is undefined" #143, all modules should have the same browser compatibility

The ugly side:

  • more tooling around (but also less manual work)
  • slower builds (more to do)
  • slower tests (more to do)

prymitive added 30 commits July 29, 2017 13:43
@prymitive
Drop jshint, use eslint in es6 mode
d91fa47
@prymitive
Rewrite watchdog using CommonJS
1474af8
@prymitive
Add basic tests for watchdog using jest
f835768
@prymitive
Fix watchdog tests
07a272e
@prymitive
Convert counter.js to CommonJS module
3c8be2d
@prymitive
Add more watchdog tests
acc99e4
@prymitive
Convert autocomplete to CommonJS and write tests
4c95f28
@prymitive
Rewrite template.js as CommonJS
4799179
@prymitive
Rewrite colors.js as CommonJS, add tests
f22959f
@prymitive
Add missing jquery require to the counter.js
839c01d
@prymitive
Rewrite progress.js as CommonJS, add tests
39204ea
@prymitive
Rewrite querystring.js as CommonJS, add basic tests
a698a40
@prymitive
Rewrite unsilence.js as CommonJS
c4f96b8
@prymitive
Fix counter package import, add stub test file
3cb3375
@prymitive
Fix grid init(), add stub tests
d083054
@prymitive
Rewrite sentry.js as CommonJS, add basic test
7301f40
@prymitive
Add basic templates test
f6ca29d
@prymitive
Rewrite summary.js as CommonJS, add tests
d166222
@prymitive
Rewrite filters.js as CommonJS, add basic test
bc7be22
@prymitive
Rewrire ui.js as CommonJS, add tests
3dd04eb
@prymitive
Fix tests
b2f9990
@prymitive
Rewrite alerts.js as CommonJS, add tests
0db288e
@prymitive
Rewrite config.js as CommonJS and split options to dedicated file, ad…
2f4cd1b 
…d basic tests
@prymitive
Rewrite silence.js as CommonJS, add basic test
ccba7f6
@prymitive
Add missing require, add basic test
15227f4
@prymitive
Rewrite unsee.js as CommonJS, add basic test
e963a3f
@prymitive
Fix watchdog requires
17f1e2c
@prymitive
Fix remaining requires
fc0cc1c
@prymitive
Add npm package config with dependencies
a19a84c
@prymitive
webpack config
56f3b01
prymitive added 5 commits July 29, 2017 16:19
@prymitive
Version all bundles
f202232 
This will tell webpack to add a hash to all bundles filenames, we generate script tags for loading those and inject them as templates. No more forced cache bypassing
@prymitive
Move all imports to head to avoid unstyled html on load
89223e8
@prymitive
Move jest coverage dir to .coverage
83f291a
@prymitive
Speedup webpack boundles generation
2c1ee0e 
we don't use moment locale and prefetch will speed up bundle generation
@prymitive
Test color.merge()
3eb1e0c
@prymitive prymitive requested review from Tenzer and terinjokes July 30, 2017 00:09
@prymitive
Cache node_modules
8cc8e50 
So we don't need to download everything on every CI run
@prymitive prymitive requested review from jamesog and mattbostock July 30, 2017 00:44
prymitive added 5 commits July 30, 2017 17:25
@prymitive
Proper behaviour tests for ui.js
bd249e4 
Checks whenever code does what it suppose to, not only if it runs
@prymitive
Mock templates so we actually load and parse all of them
2020099
@prymitive
Enable node mode in eslint and remove uneeded overrides
6bd6f63
@prymitive
Run end-to-end tests for unsee.js
b6d5a56 
This will allow to test entire alerts flow - get alerts.json response (via mocks) and render alerts
@prymitive
Add reload tests
eb21642
Tenzer
Tenzer approved these changes Aug 1, 2017
View reviewed changes
Copy link

@Tenzer Tenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO approval due to PR size.

@prymitive
Copy link
Contributor Author

prymitive commented Aug 2, 2017

This is waiting on @terinjokes to finish review

terinjokes
terinjokes approved these changes Aug 4, 2017
View reviewed changes
Copy link

@terinjokes terinjokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got bored partway through this.

.travis.yml

go_import_path: github.com/cloudflare/unsee

# install jshint & eslint, it's used for linting js files (needs nodejs)
Copy link

@terinjokes terinjokes Aug 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may consider using Travis Build Stages to run lint tests separately from unit tests.

Copy link
Contributor Author

@prymitive prymitive Aug 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider I shall

@prymitive prymitive merged commit 5773ab2 into master Aug 4, 2017
@prymitive prymitive deleted the jest branch August 4, 2017 23:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jamesog jamesog Awaiting requested review from jamesog

@mattbostock mattbostock Awaiting requested review from mattbostock

2 more reviewers

@Tenzer Tenzer Tenzer approved these changes

@terinjokes terinjokes terinjokes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prymitive @Tenzer @terinjokes