Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Comments

Show correct label colors in the silence form#149

Merged
prymitive merged 1 commit intomasterfrom
fix-silence-form-colors
Jul 26, 2017
Merged

Show correct label colors in the silence form#149
prymitive merged 1 commit intomasterfrom
fix-silence-form-colors

Conversation

@prymitive
Copy link
Contributor

When the silence form is rendered we make a new alerts.json request to pull all instances of the alert being silenced and populate select boxes, so that user can silence not only currently displayed alerts, but all firing ones. When we do that only alerts displayed (matching filters) are colored properly because only those had color data in the global state, so some instances in those select boxes will be missing color data. To fix this merge global color data (from filtered alerts) with colors for alerts we collected, so when rendering happens we have color data for all instances.

When the silence form is rendered we make a new alerts.json request to pull all instances of the alert being silenced and populate select boxes, so that user can silence not only currently displayed alerts, but all firing ones. When we do that only alerts displayed (matching filters) are colored properly because only those had color data in the global state, so some instances in those select boxes will be missing color data. To fix this merge global color data (from filtered alerts) with colors for alerts we collected, so when rendering happens we have color data for all instances.
@prymitive prymitive merged commit 9ea3236 into master Jul 26, 2017
@prymitive prymitive deleted the fix-silence-form-colors branch July 26, 2017 03:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants