This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Conversation
prymitive
force-pushed
the
unsilence-button
branch
from
5f36af4 to
29b0928
Compare
|
I think a trash/bin icon might be better for signalling that this deletes the silences. The 'X' button may make it look like the many cookie warnings people are used to on websites, where they can click the 'X' in order to dismiss the information in that box. |
prymitive
force-pushed
the
unsilence-button
branch
from
29b0928 to
c666d63
Compare
Contributor
Author
|
trash icon is ugly, but ok |
bobrik
approved these changes
Jul 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a simple "close" button on each silence, clicking will send a DELETE request to the right Alertmanager instance.