Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Comments

Tweak collected metrics#128

Merged
prymitive merged 2 commits intomasterfrom
fix-metrics
Jul 6, 2017
Merged

Tweak collected metrics#128
prymitive merged 2 commits intomasterfrom
fix-metrics

Conversation

@prymitive
Copy link
Contributor

Alert counters needs to be reset otherwise they just keep growing and aren't really counters.
Plus add a metric for number of runs.

@prymitive prymitive added the bug label Jul 6, 2017
@prymitive prymitive requested review from Tenzer and jamesog July 6, 2017 01:30
@Tenzer
Copy link

Tenzer commented Jul 6, 2017

This might not be the right place to ask, but let me try anyway. Would it be an idea to have the unsee_collected_alerts split into which receiver they are for? As it is right now it's just a total number of all alerts received for the system, but adding the receiver as a dimension would allow different teams using the same Alertmanager instance to dig into how many alerts they currently have going off.

prymitive added 2 commits July 6, 2017 08:52
Metrics were incremented but never reset, this fixes it
This way one can alert if unsee stops collecting alerts.
@prymitive
Copy link
Contributor Author

Raised #130 for receiver label

@prymitive prymitive merged commit 215ece7 into master Jul 6, 2017
@prymitive prymitive deleted the fix-metrics branch July 6, 2017 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants