Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Comments

Redraw alert list of user switches to unsee tab#127

Merged
prymitive merged 1 commit intomasterfrom
page-visibility-change
Jul 6, 2017
Merged

Redraw alert list of user switches to unsee tab#127
prymitive merged 1 commit intomasterfrom
page-visibility-change

Conversation

@prymitive
Copy link
Contributor

This should limit UI artifacts when you keep unsee tab inactive (not fucused) for a long time and a browser stops refreshing content

@Tenzer
Copy link

Tenzer commented Jul 5, 2017

@prymitive
Copy link
Contributor Author

I don't see any mention on that website that vendor prefixes aren't required. It only shows which browsers are supporting it. I think I trust mozilla docs more, demos for it, like https://github.com/samdutton/simpl/blob/gh-pages/pagevisibility/js/main.js linked from https://www.chromestatus.com/feature/5689697795833856 still uses all checks. I'd rather use mozilla example for now.

@prymitive prymitive force-pushed the page-visibility-change branch from 42b358c to ad77621 Compare July 6, 2017 16:03
@prymitive
Copy link
Contributor Author

Well, spec for it indicate that's those shouldn't be needed, and if browser implemented the spec than it shouldn't be required. Still, I'd rather rely on mozilla docs.

@Tenzer
Copy link

Tenzer commented Jul 6, 2017

If you click the "Show all" button on the page you can see the previous versions of the browsers, they had small remarks saying that it only worked with vendor prefixes but they are no longer there. Here are the latest versions of Firefox, Chrome and Opera to require vendor prefixes for instance:
screen shot 2017-07-06 at 17 04 39
screen shot 2017-07-06 at 17 04 44
screen shot 2017-07-06 at 17 04 49

The version numbers are aligned with what is mentioned on Mozilla's page, I just find Mozilla's table more difficult to read.

This should limit UI artifacts when you keep unsee tab inactive (not fucused) for a long time and a browser stops refreshing content
@prymitive prymitive force-pushed the page-visibility-change branch from ad77621 to ad47afd Compare July 6, 2017 16:13
@prymitive
Copy link
Contributor Author

Fair enough, updated

@prymitive prymitive merged commit 32553e1 into master Jul 6, 2017
@prymitive prymitive deleted the page-visibility-change branch July 6, 2017 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants