This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Collect alerts from multiple Alertmanager instances#124
Merged
Conversation
5b5afc8 to
87ecd9e
Compare
Alerts are stored per instance and deduplicated on read.
This will be more expensive but will simplify the code
This will make upgrade more explicit since there is a syntax change
21e5a4b to
612a0e8
Compare
This will make it easier to tell which tests are being run, since some are optional and depend on tools being installed
Unique uri is required for silence form result tracking
…the UI Silence result UI will now show all selected upstreams and provide individual results for each
Go 1.7 is no longer supported by Go developers (since the policy is that only latest version is supported), drop it from travis so we can use 1.8 features. There's very little excuse not to use latest Go and plenty of workarounds if someone can't install it (like using docker).
Labels fp is stable, contant fp will keep changing
…ual timestamps per instance
Alert can be silenced in one instance while active in another, always show silences so it's visible
Cache handling is done in the upstream handling code, this isn't needed anymore
…we don't need to show them all the time
Tenzer
approved these changes
Jul 2, 2017
Tenzer
left a comment
There was a problem hiding this comment.
This change is too big for me to review properly, but I'll assume you have done testing of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121, this is a big stream of changes, since adding support for multiple alertmanager instances means rewriting a lot of code.
Also fixes #37 because running Alertmanager in HA mode is pretty much the same as running 2 independent instances, HA is really only used to de-duplicate notifications, which has nothing to do with the API.
Tasks:
startsAt, this will also affect alert list sorting, which is now unstable because we use random alert instance, so the timestamp value can change all the time@receiveror@alertmanager), key names should only show up on hover, this will compensate longer list of standard buttons