This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Conversation
Update config + regenerate all mock data
Tenzer
approved these changes
Jun 6, 2017
Tenzer
left a comment
Tenzer
left a comment
There was a problem hiding this comment.
Only one minor thing but otherwise it's probably good.
alertmanager/alertmanager_test.go
Outdated
| } | ||
| if len(groups) != 6 { | ||
| if len(groups) != 10 { | ||
| t.Errorf("Got %d groups, expected 6", len(groups)) |
There was a problem hiding this comment.
This message should probably also be updated.
And change the icon, this is static text so let's remove it to save space
Number of links usually doesn't justify giving it a dedicated row, so let's render it before labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107 as unsee will now properly handle receivers and tag each alert group and alert in that group with receiver name. This means that for example all alerts configured to be pushed to hipchat can be selected with
@receiver=hipchat. Since this adds more labels to the UI it also includes some minor cleanups to give some space back.