Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Comments

Codacy fixes#108

Merged
prymitive merged 5 commits intomasterfrom
codacy-fixes
May 30, 2017
Merged

Codacy fixes#108
prymitive merged 5 commits intomasterfrom
codacy-fixes

Conversation

@prymitive
Copy link
Contributor

@prymitive prymitive added the bug label May 30, 2017
@prymitive prymitive requested review from Tenzer and jamesog May 30, 2017 11:52
@jamesog
Copy link
Contributor

jamesog commented May 30, 2017

FWIW you should see these if you run golint or gometalinter too. Running http://goconvey.co/ locally can be useful too.

@prymitive
Copy link
Contributor Author

Test target runs:

.PHONY: test
test: lint bindata_assetfs.go
        @go test -cover `go list ./... | grep -v /vendor/`

yet it didn't complain about those test files which I need to look into
but codacy does more linting, that's why I was testing it

@prymitive prymitive merged commit 2371a8a into master May 30, 2017
@prymitive prymitive deleted the codacy-fixes branch May 30, 2017 17:12
@jamesog
Copy link
Contributor

jamesog commented May 30, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants