Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Comments

Rename @status to @state#105

Merged
prymitive merged 1 commit intomasterfrom
rename-status
May 24, 2017
Merged

Rename @status to @state#105
prymitive merged 1 commit intomasterfrom
rename-status

Conversation

@prymitive
Copy link
Contributor

Fixes #104

@status filter was added to the master branch to support new status key from Alertmanager >=0.6.1
status ended up being nested in Alertmanager (it was added to solve AM issue 609 and that was a long PR with lots of changes), current unsee implementation ended being slightly off with how Alertmanager is naming this, it should actually be @State rather than @status.

Fixes #104

@status filter was added to the master branch to support new status key from Alertmanager >=0.6.1
status ended up being nested in Alertmanager (it was added to solve AM issue 609 and that was a long PR with lots of changes), current unsee implementation ended being slightly off with how Alertmanager is naming this, it should actually be @State rather than @status.
@prymitive prymitive added the bug label May 23, 2017
@prymitive prymitive added this to the v0.5 milestone May 23, 2017
@prymitive prymitive merged commit e333965 into master May 24, 2017
@prymitive prymitive deleted the rename-status branch May 24, 2017 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants