Bump undici version and minimum node version #333
Conversation
To target security vulnerabilities in undici, we update to the latest version. From undici v5.7.0, we require a node >=16.8.0 - here we update the minimum to 16.13.0 (the first Node 16 LTS release)
We should pin the version of undici
JacobMGEvans
left a comment
JacobMGEvans
left a comment
There was a problem hiding this comment.
As long as @mrbbot is good with these changes, I think it is good to go.
|
Just worth noting that this will require some people to bump their version of node - I assume we have some precedent for a release like this |
mrbbot
left a comment
mrbbot
left a comment
There was a problem hiding this comment.
Nice, thank you! 🙂 Added a couple tiny commits to fix tests, but otherwise... ✅
|
Would you be ok using 16.8.0 as the minimum version instead? Makes the breaking change radius a little smaller. |
|
The thinking here was what if |
|
That's fair. Let's land this? |
|
wait it was landed already ha |
|
...and released in |
4 participants
To target security vulnerabilities in undici, we update to the latest version.
From undici v5.7.0, we require a node >=16.8.0 - here we update the minimum to 16.13.0 (the first Node 16 LTS release)