Backport math/big prime generation algorithm from Go 1.18#59
Merged
ignatk merged 2 commits intocloudflare:mainfrom Sep 2, 2022
Merged
Backport math/big prime generation algorithm from Go 1.18#59ignatk merged 2 commits intocloudflare:mainfrom
ignatk merged 2 commits intocloudflare:mainfrom
Conversation
In Go >= 1.19 the algorithm was changed as well as explicit randomization was added. While we could mitigate the explicit randomization with maybeNotReader, the algorithm itself breaks backwards compatibility. Import the old algorithm into gokey instead.
This test was added to more easily track, when stdlib crypto/rsa algorithm changes. This now happened in Go >= 1.19 (due to changes in the math/big prime generation algorithm) and the test is correctly failing. Remove the test, so it does not confuse contributors anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Go >= 1.19 the algorithm was changed as well as explicit randomization was added. While we could mitigate the explicit randomization with
maybeNotReader, the algorithm itself breaks backwards compatibility.Import the old algorithm into gokey instead.
Fixes #58