Improvements to Github actions - added macOS,Windows + cron#48
Merged
ignatk merged 1 commit intocloudflare:masterfrom Jul 13, 2022
Merged
Conversation
IgnorantSapient
force-pushed
the
github-actions-improvements
branch
from
6675ced to
049b6b9
Compare
ignatk
reviewed
Jul 13, 2022
IgnorantSapient
force-pushed
the
github-actions-improvements
branch
2 times, most recently
from
259318b to
3131f4f
Compare
IgnorantSapient
force-pushed
the
github-actions-improvements
branch
from
3131f4f to
92e96f9
Compare
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run into issues like #45 where the CLI tool breaks for one particular OS and it is due to a bug down the dependency tree.
In order to avoid issues like this @jagger27 has made some good fixes like #43 and #40. In this PR I have
Set the pipeline to run weekly on Tuesdays to notify the maintainer about failures.Tested extensively here on my fork https://github.com/IgnorantSapient/gokey/actions/runs/2659679942