Merged
Conversation
ignatk
reviewed
Jul 12, 2022
Contributor
|
Can you squash the commits and rebase? |
IgnorantSapient
force-pushed
the
replace-deprecated-terminal-package
branch
from
4ad3aa7 to
08f78e6
Compare
Author
|
Done 👍 |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package
golang.org/x/crypto/ssh/terminalis deprecated and it has been moved togolang.org/x/term.This change has been made to reflect that, the CLI was built and tested and it works as intended.
The version of crypto has also been bumped up so that the CLI will build and run on Macs. See: #40 (It would be ideal if PR#40 is merged first before merging this)