Respect custom x509 ext in selfsign#1281
Merged
nickysemenza merged 2 commits intocloudflare:masterfrom Feb 21, 2024
Merged
Conversation
Contributor
sthussey
commented
Apr 7, 2023
sthussey
commented
- No longer ignore specified x509 extensions in the CSR when generating a self-signed certificate.
- No longer ignore specified x509 extensions in the CSR when generating a self-signed certificate.
Contributor
Author
|
This resolves issue #1280 |
Contributor
|
this looks good; is there a simple test you could add for this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1281 +/- ##
=======================================
Coverage 52.94% 52.94%
=======================================
Files 76 76
Lines 9095 9096 +1
=======================================
+ Hits 4815 4816 +1
Misses 3813 3813
Partials 467 467 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@nickysemenza Sorry for the long delay, lost track of this. I've added a test. |
- Test that a CSR custom OID extension is correctly included
in the resulting certificate
sthussey
force-pushed
the
fix/selfsign-extensions
branch
from
453d3c7 to
5ac7cd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.