Merge pull request #1187 from jonathanio/improve-ocspserve-ipv6-handling

nickysemenza · web-flow · commit 123abe0b8fdc · 2022-11-23T09:05:34.000-08:00
Improve IPv6 address handling in ocspserve
diff --git a/cli/ocspserve/ocspserve.go b/cli/ocspserve/ocspserve.go
@@ -3,8 +3,9 @@ package ocspserve
 
 import (
 	"errors"
-	"fmt"
+	"net"
 	"net/http"
+	"strconv"
 
 	"github.com/cloudflare/cfssl/cli"
 	"github.com/cloudflare/cfssl/log"
@@ -53,7 +54,7 @@ func ocspServerMain(args []string, c cli.Config) error {
 	log.Info("Registering OCSP responder handler")
 	http.Handle(c.Path, ocsp.NewResponder(src, nil))
 
-	addr := fmt.Sprintf("%s:%d", c.Address, c.Port)
+	addr := net.JoinHostPort(c.Address, strconv.Itoa(c.Port))
 	log.Info("Now listening on ", addr)
 	return http.ListenAndServe(addr, nil)
 }
