This repository was archived by the owner on Aug 31, 2021. It is now read-only.
cf-component-text to fela migration#98
Merged
sejoker merged 6 commits intocloudflare:masterfrom Mar 17, 2017
Merged
Conversation
jwineman
reviewed
Mar 16, 2017
| 'color--warning': '#fca520', | ||
| 'color--error': '#ff3100', | ||
| 'color--muted': '#gray' | ||
| }); |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
TextTheme styles are specific to our examples styles. Do we want them to be part of the cf-style-const?
Contributor
There was a problem hiding this comment.
Yes please. Also, I would rename them to colorWarning, colorError ... etc. So it's JS compatible.
Contributor
Author
There was a problem hiding this comment.
I can rename to colorwarning, colorerror easily, but camelCase format will require more work, is it worth the effort?
Contributor
There was a problem hiding this comment.
Yea, we should stay consistent and use camelCase everywhere. It's easy to do it now than later.
jwineman
reviewed
Mar 17, 2017
| 'textTransformCapitalize:first-word': 'capitalize', | ||
| textTransformLowercase: 'lowercase', | ||
| textTransformUppercase: 'uppercase', | ||
| colorInfo: '#00a9eb', |
jwineman
approved these changes
Mar 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.