migrate cf-component-heading to support Fela#97
Conversation
| @@ -0,0 +1,7 @@ | |||
| export default () => ({ | |||
| color: '#434148', | |||
There was a problem hiding this comment.
We need to move all these variables into a const file early before we start putting hex codes everywhere. @tajo does this exist yet?
There was a problem hiding this comment.
it doesn't exist, we should agree wether it should be inside cf-style-const
There was a problem hiding this comment.
I agree it should be in cf-style-const
There was a problem hiding this comment.
If it's a specific color for a specific component, we should define a variable in the global theme, and reference it locally.
.gitignore
Outdated
| packages/*/npm-debug.log.* | ||
| es | ||
| dist | ||
| .DS_Store No newline at end of file |
There was a problem hiding this comment.
This is platform specific. Do we need it? I added a global ignore for this. http://technicalpickles.com/posts/configure-git-to-globally-ignore-some-files/
There was a problem hiding this comment.
I think it's ok to have them in .gitignore, thanks for the link.
There was a problem hiding this comment.
agree, this should not be in gitignore since it's not project related
There was a problem hiding this comment.
I will remove it, no worries
|
@sejoker Why did you merge this? You ignored my whole feedback + you should wait for 2 approvals before the merge. |
|
@tajo lets force 2 approvals rule then, please point me to your feedback :) it's not due to my ignorance |
5 participants
No description provided.