This repository was archived by the owner on Aug 31, 2021. It is now read-only.
Add a creatable parameter to enable Creatable select components to be…#94
Merged
Add a creatable parameter to enable Creatable select components to be…#94
Conversation
marksteyn
requested review from
hturan,
jculvey,
jwineman,
koddsson,
prestonp,
tajo,
toekneestuck and
wyuenho
jwineman
reviewed
Mar 14, 2017
| "dependencies": { | ||
| "react": "^0.14.2 || ^15.0.0-0", | ||
| "react-select": "1.0.0-rc.2 || 1.x" | ||
| "react-select": "1.0.0-rc.3 || 1.x" |
Contributor
There was a problem hiding this comment.
I realize it was RC 2 before but shouldn't we be depending on a more stable version? Does the functionality we need exist in 1.0.0+?
Contributor
|
Please rebase. |
wyuenho
approved these changes
Mar 15, 2017
jwineman
approved these changes
Mar 15, 2017
prestonp
approved these changes
Mar 15, 2017
marksteyn
force-pushed
the
enable-creatable-select
branch
from
c661ef5 to
795cd09
Compare
Contributor
|
2 things concerning here. I've tested this on the latest nvm, node 6.10.0, and npm 3 and 4.
|
jwineman
approved these changes
Mar 15, 2017
tajo
approved these changes
Mar 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… created