boring-sys: Disable unnecessary bindgen dependencies#55
Merged
jyn514 merged 1 commit intocloudflare:masterfrom Nov 2, 2021
Merged
boring-sys: Disable unnecessary bindgen dependencies#55jyn514 merged 1 commit intocloudflare:masterfrom
jyn514 merged 1 commit intocloudflare:masterfrom
Conversation
`bindgen`'s default features include dependencies like `clap` and `env_logger` which are unnecessary when building `boring-sys`. When using tools like `cargo-deny` to audit dependencies with mismatched versions, these dependencies can easily conflict with application dependencies. This change disables `bindgen`'s default features to avoid unnecessary dependencies.
This was referenced Nov 2, 2021
Closed
jyn514
approved these changes
Nov 2, 2021
Contributor
Author
|
@jyn514 Thanks for the quick review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bindgen's default features include dependencies likeclapandenv_loggerwhich are unnecessary when buildingboring-sys. Whenusing tools like
cargo-denyto audit dependencies with mismatchedversions, these dependencies can easily conflict with application
dependencies.
This change disables
bindgen's default features to avoid unnecessarydependencies.