Conversation
bwesterb
approved these changes
Jan 31, 2026
Member
bwesterb
left a comment
bwesterb
left a comment
There was a problem hiding this comment.
Needs (basic) tests. And good to double check safety assumptions when calling each of these.
cjpatton
force-pushed
the
cjpatton/extras
branch
from
1f5f992 to
45542c1
Compare
Collaborator
Author
|
Added some tests. |
cjpatton
force-pushed
the
cjpatton/extras
branch
from
45542c1 to
1afefa4
Compare
cjpatton
commented
Feb 2, 2026
Comment on lines
+1079
to
+1084
| for cipher in [ | ||
| Cipher::aes_128_gcm(), | ||
| Cipher::aes_192_gcm(), | ||
| Cipher::aes_256_gcm(), | ||
| Cipher::des_ede3(), | ||
| ] { |
Collaborator
Author
There was a problem hiding this comment.
Reviewer note: ffi::EVP_get_cipherbyname(ffi::OBJ_nid2sn(nid.as_raw())) returns NULL for these ciphers. I'm not sure why.
kornelski
approved these changes
Feb 2, 2026
cjpatton
force-pushed
the
cjpatton/extras
branch
from
1afefa4 to
52415a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a couple small features that are useful for our internal IPsec implementation:
Cipher's NIDWe can live without both, but they would be pretty helpful.