Conversation
cjpatton
commented
Sep 29, 2025
This is incompatible with the latest internal FIPS build. Namely, the various group identifiers have been renamed since the previous version.
cjpatton
force-pushed
the
cjpatton/drop-ssl-curve
branch
from
975281d to
b1dcfbb
Compare
Instead of returning an `SslCurve`, just return the `u16` returned by BoringSSL.
cjpatton
commented
Sep 30, 2025
| } | ||
|
|
||
| /// Returns the [`SslCurve`] used for this `SslRef`. | ||
| /// Returns the curve ID (aka group ID) used for this `SslRef`. |
Collaborator
Author
There was a problem hiding this comment.
If upstream BoringSSL is moving to replace "curve" with "group" in their API, then we might want do so here and for set_curves_list as well.
Member
There was a problem hiding this comment.
It's not clear they are going to replace them since they still provide both names and the "group" APIs were added more than 2 years ago already. "group" is also not really a much better name given PQ... I think it was just for OpenSSL "compatibility".
ghedo
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API is incompatible with the latest internal FIPS build. Namely, the various group identifiers have been renamed since the previous version.