Conversation
7689231 to
6e882cb
Compare
ghedo
approved these changes
Sep 26, 2025
Contributor
|
This broke cross-compiling from macOS to Android using As you can see, it's trying to use the Android Clang with macOS compiler flags, because you've set |
Contributor
|
(To be clear, CMake already understood these target-specific CCs. cmake-rs is just getting in the way.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes parallel multi-platform builds easier.
The github workflow intentionally uses inconsistent syntax to test fallbacks in
target_var.