Hi,
thanks calling me out, I've tried to see where the issue by looking at the code, but didn't had time to setup a php7.4 env to verify it.

The issue with php 7.4 is that it now raises a notice if you try to do this:

$configVal = null;
return $configVal[0];

while before it simply returns null.

I suppose that this line is returning null and triggers the notice:

Cloudflare-WordPress/src/WordPress/Hooks.php

Line 248 in a46a7cb

    
           $cacheSettingObject = $this->dataStore->getPluginSetting(\CF\API\Plugin::SETTING_PLUGIN_SPECIFIC_CACHE);

because that traces back to a WP's get_option call that when there is no value in the DB it returns null by default. So probably the solution is to catch the null value early, something like this:

    protected function isPluginSpecificCacheEnabled()
    {
        $cacheSettingObject = $this->dataStore->getPluginSetting(\CF\API\Plugin::SETTING_PLUGIN_SPECIFIC_CACHE);

        if (  $cacheSettingObject === null || !isset($cacheSettingObject[\CF\API\Plugin::SETTING_VALUE_KEY]) ){
            return false;
        }

        $cacheSettingValue = $cacheSettingObject[\CF\API\Plugin::SETTING_VALUE_KEY];

        return isset($cacheSettingValue) && $cacheSettingValue !== false && $cacheSettingValue !== 'off';
    }

If you want to try to edit the code on live site and let me know, I found little tricky to debug this plugin because it can't be full-activated on local dev environments. I'll try in the next weeks and if the solution works, I can write a PR.

PHP 7.4 compatibility #251

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions