Sync CESQL tck tests #603
Merged
Sync CESQL tck tests #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <[email protected]>
pierDipi
approved these changes
Jan 31, 2024
pierDipi
reviewed
Jan 31, 2024
Member
There was a problem hiding this comment.
I just realized that the tests failures are hidden, and the CI doesn't fail
If you apply this diff you will get errors in the tests:
diff --git a/sql/src/test/java/io/cloudevents/sql/TCKTestSuite.java b/sql/src/test/java/io/cloudevents/sql/TCKTestSuite.java
index d48b7a3..82c2997 100644
--- a/sql/src/test/java/io/cloudevents/sql/TCKTestSuite.java
+++ b/sql/src/test/java/io/cloudevents/sql/TCKTestSuite.java
@@ -124,8 +124,7 @@ public class TCKTestSuite {
try {
return mapper.readValue(this.getClass().getResource(fileName), TestSuiteModel.class);
} catch (IOException e) {
- e.printStackTrace();
- return null;
+ throw new RuntimeException(fileName, e);
}
})
.filter(Objects::nonNull)
Member
|
Even after fixing the |
Contributor
Author
As far as I can tell, the test failure is do to a mistake in the actual tck test case, where it is expecting the wrong result. I'll open a PR to spec with the fixes to the tck tests and then pull those changes in here |
touchkey
pushed a commit
to touchkey/sdk-java
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Calum Murray <[email protected]> Signed-off-by: vbhat6 <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently realized that the tck tests for CESQL are not up to date with the new ones added in the spec repo. This PR just copies those changes over into sdk-java, and registers the new test file.
cc @duglin @pierDipi