Skip to content

Conversation

@robp94
Copy link

@robp94 robp94 commented Apr 28, 2023

No description provided.

@robp94
Copy link
Author

robp94 commented Apr 28, 2023

@pierDipi ok, let's see if it builds. What do you want to check else if it is backward compatible? I looked over the changes and there seem to be no real changes, only additions. But I am not too familiar with the project.

@robp94 robp94 changed the title 2.4 Backport Restful-ws jakarta ee9 namespace support #469 to 2.4 Apr 28, 2023
abutch3r and others added 3 commits May 2, 2023 09:47
* Replace javax restful-ws namespace usage with jakarata in own module
* Add microprofile with openliberty example using new jar
* Update gitignore to cover all copied directories
* Update Jersey Version to support jakarta.* namespace packages
* Port jersey integration tests from javax.* to jakarta.*
* Undo changes to existing integration test package names
* Add Integration test for Microprofile/Liberty for Jee9 package
* Add documentation for new Jakarta package

Signed-off-by: alex-butcher <[email protected]>
(cherry picked from commit f08a099)
Signed-off-by: Robert Pospisil <[email protected]>
Signed-off-by: Robert Pospisil <[email protected]>
Signed-off-by: Robert Pospisil <[email protected]>
@pierDipi pierDipi changed the base branch from 2.4 to 2.5 May 10, 2023 08:45
@pierDipi pierDipi changed the title Backport Restful-ws jakarta ee9 namespace support #469 to 2.4 Backport Restful-ws jakarta ee9 namespace support #469 to 2.5 May 10, 2023
@pierDipi
Copy link
Member

pierDipi commented May 10, 2023

Thanks for the PR @robp94, I believe it's better to release this in 2.5, I've just created a 2.5 branch based on 2.4 and updated the PR to target 2.5.

Let's see how the build goes.

@pierDipi pierDipi self-requested a review May 10, 2023 08:48
@robp94
Copy link
Author

robp94 commented May 10, 2023

@pierDipi ok nice, build was successful.

@robp94 robp94 marked this pull request as ready for review May 10, 2023 12:49
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierDipi pierDipi merged commit 3399747 into cloudevents:2.5 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants