Make ProtoCloudEventData consistent with spec. #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierDipi
reviewed
Mar 7, 2023
Member
pierDipi
left a comment
pierDipi
left a comment
There was a problem hiding this comment.
Do we have or can we add tests on the new getAny when data is binary_data or text_data [1] ?
Contributor
Author
Yes .. in two situations:
|
pierDipi
reviewed
Mar 8, 2023
formats/protobuf/src/main/java/io/cloudevents/protobuf/ProtoDataWrapper.java
Outdated
Show resolved
Hide resolved
formats/protobuf/src/main/java/io/cloudevents/protobuf/ProtoSerializer.java
Show resolved
Hide resolved
Signed-off-by: Jem Day <[email protected]>
pierDipi
approved these changes
Mar 10, 2023
skepticoitusInteruptus
pushed a commit
to skepticoitusInteruptus/sdk-java
that referenced
this pull request
Mar 23, 2023
Modified ProtoCloudEventData to always return a Protobuf Any object - this ensures it is coherent with the Protobuf CloudEvent format specification. It remains possible to wrap any Protobuf 'Message' object directly (which includes an 'Any') as a convienience to reduce application code. Signed-off-by: Jem Day <[email protected]> Signed-off-by: Randi Sheaffer-Klass <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified ProtoCloudEventData to always return a Protobuf Any object - this ensures it is coherent with the Protobuff CloudEvent format specification.
It remains possible to wrap any Protobuf 'Message' object directly (which includes an 'Any') as a convienience to reduce application code.
Closes #532