Skip to content

[ISSUE #521]Remove unused import #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierDipi merged 2 commits into from
Feb 20, 2023
Merged

[ISSUE #521]Remove unused import #522

pierDipi merged 2 commits into from
Feb 20, 2023

Conversation

@mxsm
Copy link
Contributor

@mxsm mxsm commented Feb 18, 2023

close #521

  • Remove unused import

@mxsm mxsm force-pushed the mxsm-521 branch 2 times, most recently from 3506ada to 10b3bbd Compare February 18, 2023 12:59
pierDipi
pierDipi reviewed Feb 20, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

examples/restful-ws-quarkus/src/test/java/io/cloudevents/examples/quarkus/UserResourceTest.java Outdated
import io.quarkus.test.junit.QuarkusTest;
import org.junit.jupiter.api.Test;


Copy link
Member

@pierDipi pierDipi Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this empty line? Can we remove it?

Copy link
Contributor Author

@mxsm mxsm Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi I will remove it and resbumit this pr later.

Copy link
Member

@pierDipi pierDipi Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

You can alternatively accept this suggestion

@mxsm mxsm requested a review from pierDipi February 20, 2023 12:52
@mxsm
Copy link
Contributor Author

mxsm commented Feb 20, 2023

@pierDipi PTAL~ thanks

pierDipi
pierDipi approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@pierDipi pierDipi merged commit d64aff7 into cloudevents:main Feb 20, 2023
@mxsm mxsm deleted the mxsm-521 branch February 21, 2023 02:47
skepticoitusInteruptus pushed a commit to skepticoitusInteruptus/sdk-java that referenced this pull request Mar 23, 2023
@mxsm @skepticoitusInteruptus
[cloudevents#521] Remove unused imports (cloudevents#522)
8ccdc0f 
Signed-off-by: mxsm <[email protected]>
Signed-off-by: Randi Sheaffer-Klass <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unused import

2 participants

@mxsm @pierDipi