Initial Implementation of XML Format #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierDipi
reviewed
Apr 21, 2022
formats/xml/src/main/java/io/cloudevents/xml/XMLDeserializer.java
Outdated
Show resolved
Hide resolved
formats/xml/src/main/java/io/cloudevents/xml/XMLDeserializer.java
Outdated
Show resolved
Hide resolved
formats/xml/src/main/resources/META-INF/services/io.cloudevents.core.format.EventFormat
Outdated
Show resolved
Hide resolved
pierDipi
reviewed
Jan 2, 2023
Signed-off-by: Day, Jeremy(jday) <[email protected]> Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Day, Jeremy(jday) <[email protected]> Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Day, Jeremy(jday) <[email protected]> Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Day, Jeremy(jday) <[email protected]> Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Day, Jeremy(jday) <[email protected]> Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Day, Jeremy(jday) <[email protected]> Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Day, Jeremy(jday) <[email protected]> Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Day, Jeremy(jday) <[email protected]> Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Day, Jeremy(jday) <[email protected]> Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Day, Jeremy(jday) <[email protected]> Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Jem Day <[email protected]>
Signed-off-by: Jem Day <[email protected]>
pierDipi
reviewed
Jan 5, 2023
formats/xml/src/main/java/io/cloudevents/xml/XMLSerializer.java
Outdated
Show resolved
Hide resolved
pierDipi
reviewed
Jan 5, 2023
Signed-off-by: Jem Day <[email protected]>
pierDipi
reviewed
Jan 9, 2023
| class XMLUtils { | ||
|
|
||
| private static final Pattern XML_PATTERN = Pattern.compile("^(application|text)\\/([a-zA-Z]+\\+)?xml(;.*)*$"); | ||
| private static final Pattern TEXT_PATTERN = Pattern.compile("^application\\/([a-zA-Z]+\\+)?(xml|json)(;.*)*$"); |
Member
There was a problem hiding this comment.
We're adding json too because it's a common / well known "text-based format", right?
Contributor
Author
There was a problem hiding this comment.
Yes ... any text/* content-types are caught in the utility function without using the regex (to keep it simpler!).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #446