Handle NullNode for optional attributes in Jackson CloudEventDeserializer #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izer In `getOptionalStringNode` we should handle `JsonNode`s that are instances of `NullNode`. Signed-off-by: Pierangelo Di Pilato <[email protected]>
JapuDCret
reviewed
Dec 21, 2021
formats/json-jackson/src/main/java/io/cloudevents/jackson/CloudEventDeserializer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pierangelo Di Pilato <[email protected]>
JapuDCret
approved these changes
Dec 21, 2021
pierDipi
added a commit
to pierDipi/sdk-java
that referenced
this pull request
Dec 21, 2021
…izer (cloudevents#432) In `getOptionalStringNode` we should handle `JsonNode`s that are instances of `NullNode`. Signed-off-by: Pierangelo Di Pilato <[email protected]>
Member
Author
|
Cherry pick for 2.2.1-SNAPSHOT: #433 |
pierDipi
added a commit
that referenced
this pull request
Dec 21, 2021
…izer (#432) (#433) In `getOptionalStringNode` we should handle `JsonNode`s that are instances of `NullNode`. Signed-off-by: Pierangelo Di Pilato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
getOptionalStringNodewe should handleJsonNodes that areinstances of
NullNode.Fixes #430