Whait db close a little bit before failing test

iilyak · iilyak · commit 4683f51eb848 · 2017-05-19T10:56:53.000-07:00
Databases are closed asynchronously. However it was not accounted for in
the test case. This commit waits database to close before it makes a
decission to abort the test.
I.e. if test case detects that database is still opened after 1 second
it considers it as failure.
diff --git a/src/couch_index/test/couch_index_compaction_tests.erl b/src/couch_index/test/couch_index_compaction_tests.erl
@@ -15,6 +15,8 @@
 -include_lib("couch/include/couch_eunit.hrl").
 -include_lib("couch/include/couch_db.hrl").
 
+-define(WAIT_TIMEOUT, 1000).
+
 setup() ->
     DbName = ?tempdb(),
     {ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
@@ -86,10 +88,18 @@ hold_db_for_recompaction({Db, Idx}) ->
             throw(timeout)
         end,
 
-        ?assertNot(is_opened(Db)),
+        ?assertEqual(ok, wait_db_close(Db)),
         ok
     end).
 
+wait_db_close(Db) ->
+    test_util:wait(fun() ->
+        case is_opened(Db) of
+            false -> ok;
+            true -> wait
+        end
+    end, ?WAIT_TIMEOUT).
+
 is_opened(Db) ->
     Monitors = [M || M <- couch_db:monitored_by(Db), M =/= self()],
     Monitors /= [].
