block: allow VIRTIO_BLK_T_GET_ID for read-only devices #7546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrewster
force-pushed
the
cb-virtio-blk-ro-getdeviceid
branch
2 times, most recently
from
a1a450e to
6503daf
Compare
Member
|
@cbrewster Thank you for change - looks good. Please make sure you read CONTRIBUTING.md. In particular the note about DCO sign off on the commits. |
cloud-hypervisor#7294 adjusted the checks for read-only requests made to virtio-blk devices and started rejecting VIRTIO_BLK_T_GET_ID requests. These requests do not perform any writes and are needed in order to access device serials from within the guest. Signed-off-by: Connor Brewster <[email protected]>
cbrewster
force-pushed
the
cb-virtio-blk-ro-getdeviceid
branch
from
6503daf to
be17dca
Compare
Contributor
Author
|
@rbradford I updated the commit with the DCO sign off, thanks for taking a look! |
rbradford
approved these changes
Dec 8, 2025
russell-islam
approved these changes
Dec 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
cloud-hypervisor:main
with commit Dec 9, 2025
41a8dcd
42 of 44 checks passed
github-project-automation
bot
moved this from 🆕 New
to ✅ Done
in Cloud Hypervisor Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7294 adjusted the checks for read-only requests made to virtio-blk devices and started rejecting VIRTIO_BLK_T_GET_ID requests. These requests do not perform any writes and are needed in order to access device serials from within the guest.