vmm: small code cleanups #7511
Merged
vmm: small code cleanups #7511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
phip1611
changed the title
map_err -> inspect_err)
phip1611
changed the title
map_err -> inspect_err)
rbradford
reviewed
Nov 25, 2025
| apply_filter(&seccomp_filter) | ||
| .map_err(Error::ApplySeccompFilter) | ||
| .map_err(|e| { | ||
| .inspect_err(|e| { |
Member
There was a problem hiding this comment.
Cool - didn't know about this. Could you elaborate more in your commit message what you're doing here.
This is continuing the work from [0]. Some places in CHV "misuse" Result::map_err for side-effects. inspect_err is a better suited alternative for exactly that use-case. Unfortunately, there is no clippy lint for this yet. [0] f02745a Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
On-behalf-of: SAP [email protected] Signed-off-by: Julian Stecklina <[email protected]>
phip1611
force-pushed
the
upstream-inspect-err
branch
from
8c65c4c to
800f295
Compare
rbradford
approved these changes
Nov 25, 2025
Merged
via the queue into
cloud-hypervisor:main
with commit Nov 25, 2025
8c50450
41 of 43 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work from f02745a.
Unfortunately, there is no clippy lint for this yet.
Part of #7489