Use qemu-img to check disk consistency after tests where applicable #7506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a common use case to run a subset of tests locally to verify certain functionalities. The default behaviour for nextest is to error out if no tests are run. That causes the test scripts to return a non-zero value (failure). Pass `--no-tests=pass` to nextest to match what `cargo test` does if no tests are run. Signed-off-by: Wei Liu <[email protected]>
liuw
force-pushed
the
tests-check-disk-consistency
branch
from
19958eb to
3240203
Compare
phip1611
requested changes
Nov 25, 2025
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
Overall, it looks good to me. I left a few remarks
liuw
force-pushed
the
tests-check-disk-consistency
branch
from
3240203 to
0d963b0
Compare
We've encountered issues that Cloud Hypervisor corrupts disk images after use. Those issues may not be immediately obvious until the corrupted images are used again. Run consistency checks over the disk images in the test cases to catch issues as early as possible. Signed-off-by: Wei Liu <[email protected]>
liuw
force-pushed
the
tests-check-disk-consistency
branch
from
0d963b0 to
a55264b
Compare
phip1611
approved these changes
Nov 25, 2025
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
LGTM! Thanks for unifying the function - very nice
rbradford
approved these changes
Nov 25, 2025
Merged
via the queue into
cloud-hypervisor:main
with commit Nov 25, 2025
dda89d7
41 of 43 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.