Quality of Life Improvement: enable cargo test --workspace: via #[cfg(chv_testenv)]
#7487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
commented
Nov 18, 2025
phip1611
force-pushed
the
upstream-cargo-test
branch
2 times, most recently
from
2d1b352 to
2647724
Compare
phip1611
changed the title
cargo test --workspace: via #[cfg(chv_testenv)]
Closed
3 tasks
rbradford
reviewed
Nov 18, 2025
Cargo.toml
Outdated
|
|
||
| [workspace.lints.rust] | ||
| # `level = warn` is irrelevant here but mandatory for rustc/cargo | ||
| unexpected_cfgs = { level = "warn", check-cfg = ['cfg(chv_testenv)'] } |
Member
There was a problem hiding this comment.
Great idea - but can I suggest "devcli_testenv" as the name - I think it's a more descriptive name of the test environment and also reflects when it gets set.
likebreath
reviewed
Nov 18, 2025
Member
likebreath
left a comment
likebreath
left a comment
There was a problem hiding this comment.
Thank you for your investment of time in improving the developer experience. 👍
TL;DR: Massive quality of life improvement for devs Cloud Hypervisor uses the Cargo test framework for multiple tests: - normal unit tests - unit tests requiring special environment (the Tap device tests) - integration tests requiring a special environment This prevented the execution of `cargo test --workspace`, which results in a very poor developer experience. Although `./scripts/run_unit_tests.sh` exists, there are valid reasons why devs cannot or even don't want to use it. By adding a new `chv_testenv` rustc config, we can conditionally only activate tests when the `./scripts/` magic runs them. This improves the general developer experience by a lot. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
This better aligns with the rest of the code and makes it clearer that these tests can run "as is" in a normal hosted environments without the special test environment. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
upstream-cargo-test
branch
from
86dd898 to
6c292ae
Compare
likebreath
approved these changes
Nov 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
13 tasks
Merged
via the queue into
cloud-hypervisor:main
with commit Nov 20, 2025
11d17fb
44 of 45 checks passed
This was referenced Nov 27, 2025
13 tasks
phip1611
added a commit
to phip1611/nixpkgs
that referenced
this pull request
Jan 6, 2026
Since v50.0, Cloud Hypervisor unit test "just works" without restrictions [0]. [0] cloud-hypervisor/cloud-hypervisor#7487 On-behalf-of: SAP [email protected] Signed-off-by: Philipp Schuster <[email protected]>
phip1611
added a commit
to phip1611/nixpkgs
that referenced
this pull request
Jan 6, 2026
[0] cloud-hypervisor/cloud-hypervisor#7487 On-behalf-of: SAP [email protected] Signed-off-by: Philipp Schuster <[email protected]>
Open
13 tasks
phip1611
added a commit
to phip1611/nixpkgs
that referenced
this pull request
Jan 6, 2026
I want to help keep libvirt updated, as it is often quite behind. I work actively with libvirt as part of my virtualization work at Cyberus Technology. [0] cloud-hypervisor/cloud-hypervisor#7487 Signed-off-by: Philipp Schuster <[email protected]>
13 tasks
hustlerone
pushed a commit
to hustlerone/nixpkgs-kmscon-no-drm
that referenced
this pull request
Jan 7, 2026
I want to help keep libvirt updated, as it is often quite behind. I work actively with libvirt as part of my virtualization work at Cyberus Technology. [0] cloud-hypervisor/cloud-hypervisor#7487 Signed-off-by: Philipp Schuster <[email protected]>
vdemeester
pushed a commit
to vdemeester/nixpkgs
that referenced
this pull request
Jan 9, 2026
I want to help keep libvirt updated, as it is often quite behind. I work actively with libvirt as part of my virtualization work at Cyberus Technology. [0] cloud-hypervisor/cloud-hypervisor#7487 Signed-off-by: Philipp Schuster <[email protected]>
vdemeester
pushed a commit
to vdemeester/nixpkgs
that referenced
this pull request
Jan 10, 2026
I want to help keep libvirt updated, as it is often quite behind. I work actively with libvirt as part of my virtualization work at Cyberus Technology. [0] cloud-hypervisor/cloud-hypervisor#7487 Signed-off-by: Philipp Schuster <[email protected]>
vdemeester
pushed a commit
to vdemeester/nixpkgs
that referenced
this pull request
Jan 11, 2026
I want to help keep libvirt updated, as it is often quite behind. I work actively with libvirt as part of my virtualization work at Cyberus Technology. [0] cloud-hypervisor/cloud-hypervisor#7487 Signed-off-by: Philipp Schuster <[email protected]>
vdemeester
pushed a commit
to vdemeester/nixpkgs
that referenced
this pull request
Jan 12, 2026
I want to help keep libvirt updated, as it is often quite behind. I work actively with libvirt as part of my virtualization work at Cyberus Technology. [0] cloud-hypervisor/cloud-hypervisor#7487 Signed-off-by: Philipp Schuster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Massive quality of life improvement for devs
Please review this commit-by-commit.
Cloud Hypervisor uses the Cargo test framework for multiple tests:
This prevented the execution of
cargo test --workspace, which resultsin a very poor developer experience. Although
./scripts/run_unittests.shexists, there are valid reasons why people can not or even don't want to
use them.
By adding a new
chv_testenvrustc config, we can conditionally onlyactivate tests when the
./scripts/magic runs them.