[WIP] vmm: migration: virtio-net devices with external FDs #7379
Conversation
phip1611
force-pushed
the
productize-net-fd-migration
branch
from
e0fd975 to
7780730
Compare
phip1611
changed the title
phip1611
force-pushed
the
productize-net-fd-migration
branch
from
7780730 to
3640817
Compare
phip1611
changed the title
| if let Some(cfgs) = &mut net_cfg.net_fds { | ||
| let mut cfgs = cfgs.iter_mut().collect::<Vec<&mut _>>(); | ||
| let cfgs = cfgs.as_mut_slice(); | ||
| attach_fds_to_cfgs(files, cfgs)?; |
There was a problem hiding this comment.
btw: this single line is the reason why we merged #7281 - one common single abstraction (attach_fds_to_cfgs) - lovely!
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
productize-net-fd-migration
branch
from
3640817 to
2dcc552
Compare
phip1611
changed the title
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This block doesn't look like it does anything other than increase the indentation level.
| existing_memory_files.take(), | ||
| )?); | ||
|
|
||
| // TODO: add something like self.vm_config.apply_fds()? |
There was a problem hiding this comment.
Are there other places we already have code like this, or not yet?
| if net_config.id == Some(net.id.clone()) | ||
| && net_config.fds.is_some() | ||
| { | ||
| net_config.fds.clone_from(&net.fds); |
There was a problem hiding this comment.
We could consume receive_data_migration.net_fds and avoid a clone, right? (Not that it's a big deal.)
There was a problem hiding this comment.
yes, this originates from early quick and dirty prototyping. Already fixed locally (not pushed yet)
|
Postponed until #7431 is resolved and we agreed on a strategy. |
|
Not urgent - we wait a little here because of #7431 |
2 participants
Building on the foundations merged as part of #7281, we can now easily support live-migration support for virtio-net devices and external FDs.
Part of #7291. Closes #7054
Steps to Undraft