vmm: allow net devices without ip and mask #7365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbradford
reviewed
Sep 18, 2025
mguentner
force-pushed
the
mguentner/cli_optional_ip_and_mask
branch
from
75a2ac3 to
7bd4fa2
Compare
rbradford
reviewed
Sep 18, 2025
alyssais
approved these changes
Sep 19, 2025
mguentner
force-pushed
the
mguentner/cli_optional_ip_and_mask
branch
3 times, most recently
from
cba7bf5 to
a2fdaf9
Compare
Contributor
Author
|
As far as I can see, the test failure looks like a flaky test |
phip1611
reviewed
Sep 22, 2025
phip1611
reviewed
Sep 22, 2025
phip1611
approved these changes
Sep 22, 2025
This change enables easier integration with third-party tools by removing the requirement for a dummy IP address when configuring tap devices. The modification applies to both CLI and API interactions. Previously, cloud-hypervisor would automatically set a default static IP address (192.168.249.1) if none was provided. This could lead to: * multiple devices without explicit IP configurations would end up with the same default IP * unnecessary inclusion of this IP in firewall rules * the IP address could clash with host networking and routing This introduces a new constraint: When providing an IP, the mask must also be provided. Removes warnings introduced in cloud-hypervisor#7179. Closes issue cloud-hypervisor#7083. Signed-off-by: Maximilian Güntner <[email protected]>
mguentner
force-pushed
the
mguentner/cli_optional_ip_and_mask
branch
from
a2fdaf9 to
8b70c66
Compare
rbradford
approved these changes
Sep 22, 2025
Member
rbradford
left a comment
rbradford
left a comment
There was a problem hiding this comment.
Thank you for your patience on getting this in!
Merged
via the queue into
cloud-hypervisor:main
with commit Sep 22, 2025
66aa074
48 of 49 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables easier integration with third-party tools by removing the requirement for a dummy IP address when configuring tap devices. The modification applies to both CLI and API interactions.
Previously, cloud-hypervisor would automatically set a default static IP address (192.168.249.1) if none was provided.
This could lead to:
Removes warnings introduced in #7179.
Closes issue #7083.
Supersedes #7076