vmm: error if landlock can't be enabled #7335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the user has to explicitly ask for Landlock to be enabled in Cloud Hypervisor, it's surprising that, even when they've done that, Landlock will silently not be enabled if the kernel doesn't support it. To prevent accidental absence of a desired security protection, exit with an error if Landlock, or the one feature of it we use in Cloud Hypervisor (file access) is not supported. Signed-off-by: Alyssa Ross <[email protected]>
alyssais
force-pushed
the
landlock-error
branch
from
1822d60 to
fc8d6da
Compare
rbradford
approved these changes
Sep 9, 2025
Merged
via the queue into
cloud-hypervisor:main
with commit Sep 9, 2025
6cac99b
40 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the user has to explicitly ask for Landlock to be enabled in Cloud Hypervisor, it's surprising that, even when they've done that, Landlock will silently not be enabled if the kernel doesn't support it.
To prevent accidental absence of a desired security protection, exit with an error if Landlock, or the one feature of it we use in Cloud Hypervisor (file access) is not supported.