[WIP] misc debugabillity and traceability improvements #7280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One can call `to_vec()` anyway if one needs an owned copy. This change further helps to prevent needless copies in upcoming changes. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
productize-network_fd_livemig_prep-3
branch
2 times, most recently
from
078b212 to
f58f1d0
Compare
6 tasks
During development this new message helps to quickly parse the logs for success. In case this message is not shown but the last message is not an error, one can assume that likely a livelock (locking a contended lock) is the cause of the problem. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
TL;DR: Without these helpful logging messages, we (Cyberus Technology) would not have been able to refactor large parts of the CH driver in libvirt and to productize things. Upstream libvirt patches will follow within the next weeks and months. To ease debugging of networking in the field, especially in context of libvirt, state save/resume, and live-migration, more logging helps to identify what happens behind the scenes in certain corner-cases as well as (apparently) normal operation. For example: There are multiple ways to create virtio-net devices: - with vhost-user backend - from provided network FDs - from provided interface name of Tap device is given - Tap device is created by CHV (fallback) To confirm that the expected behavior occurs—especially in the more complex case of network file descriptors—these logging statements provide valuable insight into the system's internal operations. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
productize-network_fd_livemig_prep-3
branch
from
36f2a37 to
398510d
Compare
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
productize-network_fd_livemig_prep-3
branch
from
398510d to
edd89ea
Compare
8 tasks
phip1611
changed the title
phip1611
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7291 to work towards live-migration with FDs for virtio-net devices.
Misc improvements to debugabillity and traceability improvements.
TL;DR: Without these helpful logging messages, we (Cyberus
Technology) would not have been able to refactor large parts
of the CH driver in libvirt and to productize things. Upstream
libvirt patches will follow within the next weeks and months.
Steps to Undraft