[WIP] devices: remove preserved fds on device hot detach #7278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
productize-network_fd_livemig_prep-1
branch
5 times, most recently
from
0638a8b to
3d7b156
Compare
phip1611
changed the title
phip1611
changed the title
6 tasks
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Close all file descriptors opened externally for this device. This allows management software (e.g., libvirt) to properly close tap devices after a hot-remove operation. Background: virtio-net devices are currently the only devices for that you can pass externally opened FDs. This works via UNIX SCM_RIGHTS messages via the UNIX domain socket between the management software (e.g., libvirt) and Cloud Hypervisor. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
productize-network_fd_livemig_prep-1
branch
from
3d7b156 to
515bb97
Compare
8 tasks
phip1611
changed the title
phip1611
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7291 to work towards live-migration with FDs for virtio-net devices.
About
This implements the closing of all file descriptors opened externally for a certain device. This allows management software (e.g., libvirt) to properly close tap devices after a hot-remove operation.
Background: virtio-net devices are currently the only devices for that you can pass externally opened FDs. This works via UNIX SCM_RIGHTS messages via the UNIX domain socket between the management software (e.g., libvirt) and Cloud Hypervisor.
Steps to Undraft