misc: Fix beta clippy issues & Bump MSRV to 1.87.0 #7241
Conversation
lisongqian
changed the title
lisongqian
force-pushed
the
fix-beta-clippy
branch
2 times, most recently
from
e2cb545 to
3cefdd7
Compare
likebreath
left a comment
likebreath
left a comment
There was a problem hiding this comment.
@lisongqian Thank you for fixing the clippy issues. Overall looks good to me. Few legit issues being caught by the CI workers.
For risc-v worker, I guess the reason is that we only test on MSRV, and issues will only be reported with MSRV bump.
--> arch/src/riscv64/fdt.rs:451:31
|
451 | Ok(value_cstr) => match value_cstr.to_str() {
| _______________________________^
452 | | Ok(value_str) => Some(value_str),
453 | | Err(_e) => None,
454 | | },
| |_____________^ help: replace with: `value_cstr.to_str().ok()`
|
The link checker also found a real issue. It would be good to be fixed, but fine if you can't find the alternative resource:
Error: https://static.docs.arm.com/ihi0069/c/IHI0069C_gic_architecture_specification.pdf | Network error: error sending request for url (https://static.docs.arm.com/ihi0069/c/IHI0069C_gic_architecture_specification.pdf) Maybe a certificate error?
3cefdd7 to
f170922
Compare
The clippy issues and link checker issue have been fixed. But I meet new errors when building mod on RISC-V. Do you have any suggestions? @likebreath @RuoqingHe |
RuoqingHe
left a comment
RuoqingHe
left a comment
There was a problem hiding this comment.
The clippy issues and link checker issue have been fixed. But I meet new errors when building mod on RISC-V. Do you have any suggestions? @likebreath @RuoqingHe
Fixed by restarting those cases
Fix clippy error: "error: manual implementation of `.is_multiple_of() `" from rustc 1.90.0-beta.1 (788da80fc 2025-08-04). Signed-off-by: Songqian Li <[email protected]>
rustc 1.90.0-beta.1 (788da80fc 2025-08-04) suggests using library feature `unsigned_is_multiple_of`. It is stabled in Rust 1.87.0. Update image to 20250807-0 since MSRV in Dockerfile is updated. Signed-off-by: Songqian Li <[email protected]> Signed-off-by: Bo Chen <[email protected]>
Replacing pdf link with new available link to fix the failed CI. Signed-off-by: Songqian Li <[email protected]>
likebreath
force-pushed
the
fix-beta-clippy
branch
from
49b9eaa to
9f2dab5
Compare
|
Great. Thanks, folks. Updated the container tag to |
3 participants
This patch fixes clippy issues from rustc 1.90.0-beta.1 (788da80fc 2025-08-04) and bump MSRV to 1.87.0 since rustc 1.90.0-beta.1 suggests using the library feature
unsigned_is_multiple_of. It is stable in Rust 1.87.0.Signed-off-by: Songqian Li [email protected]