misc: small improvements to error messages #7106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
11 tasks
phip1611
changed the title
jinankjain
approved these changes
May 28, 2025
up2wing
reviewed
May 28, 2025
| PoisonedState, | ||
|
|
||
| #[error("Error from device manager: {0:?}")] | ||
| #[error("Failed to create the VMs devices: {0:?}")] |
Contributor
There was a problem hiding this comment.
Well, in my opion, the new code seems not quite so rigorous.
The Error::DeviceManager may also be called in add_device/resize(), which may confuse people using "create the VMs devices".
likebreath
requested changes
May 28, 2025
Member
likebreath
left a comment
likebreath
left a comment
There was a problem hiding this comment.
@up2wing is right. This is a generic error for DeviceManager to be propagated to the upper level e.g. Vm and Vmm. So I think it is better to keep as it is.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split-out from #7066 for better reviewability.