Don't allow resizing VM to 0 vCPUs #7086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No sane guest OS will allow hotplugging all cpus. However, the REST API currently allows specifying `ch-remote resize --cpus 0`. On Linux, we can then observe the following error in the kernel log: processor cpu0: Offline failed. Subsequent resize commands via ch-remote will then fail with VcpuPendingRemovedVcpu because the removal of cpu0 was never successful. Fix this by disallowing resizing to zero vCPUs. Signed-off-by: Thomas Prescher <[email protected]> On-behalf-of: SAP [email protected]
tpressure
force-pushed
the
disallow_zero_vcpus
branch
from
471b327 to
2ec5ca2
Compare
rbradford
approved these changes
May 21, 2025
Member
|
Thanks! |
phip1611
approved these changes
May 21, 2025
Merged
via the queue into
cloud-hypervisor:main
with commit May 21, 2025
d465175
38 of 39 checks passed
likebreath
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No sane guest OS will allow hotplugging all cpus.
However, the REST API currently allows specifying
ch-remote resize --cpus 0, contrary to what is specified.On Linux, we can then observe the following error in the kernel log:
processor cpu0: Offline failed.Subsequent resize commands via ch-remote will then fail with
VcpuPendingRemovedVcpubecause the removal of cpu0 was never successful.Fix this by disallowing resizing to zero vCPUs.