vmm: allow net devices without ip and mask #7076
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Doesn't this break the "API" by removing the default IP and mask. Long term I think this makes sense but we need to handle this by warning for a couple of releases when no explicit IP & mask is provided and then we can remove the default. |
Contributor
Author
|
The API in terms of parameters and syntax does not change, however the behavior does. I'd say it is a soft-breakage and may |
Member
|
Please open an issue rather than a PR and then we can plan this. |
mguentner
force-pushed
the
cli_optional_ip_and_mask
branch
from
03d9e51 to
fb218a7
Compare
mguentner
force-pushed
the
cli_optional_ip_and_mask
branch
from
fb218a7 to
835af55
Compare
This change enables easier integration with third-party tools by removing the requirement for a dummy IP address when configuring tap devices. The modification applies to both CLI and API interactions. Previously, cloud-hypervisor would automatically set a default static IP address (192.168.249.1) if none was provided. This could lead to: * multiple devices without explicit IP configurations would end up with the same default IP * unnecessary inclusion of this IP in firewall rules * the IP address could clash with host networking and routing Signed-off-by: Maximilian Güntner <[email protected]>
mguentner
force-pushed
the
cli_optional_ip_and_mask
branch
from
835af55 to
29767c3
Compare
Member
|
Let's move the discussion to #7083. Closing the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables easier integration with third-party tools by removing the requirement for a dummy IP address when configuring tap devices.
The modification applies to both CLI and API interactions.
Previously, cloud-hypervisor would automatically set a default static IP address (192.168.249.1) if none was provided.
This could lead to: