pci: Keep detect_bar_reprogramming internal to PciConfiguration #7057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likebreath
force-pushed
the
0509/refactor_detect_bar_reprog
branch
from
a0116d0 to
f808864
Compare
This was referenced May 10, 2025
A BAR reprogramming of a PCI device will only happen when the (guest) kernel write to its PCI config space, e.g. the detection of bar reprogramming (`detect_bar_repgraomming()`) can be embedded to the PCI config space write (`write_config_register()`). It simplifies APIs exposed by the `struct PciConfiguration` and `trait PciDevice`. It also prepares for easier handling of pending bar reprogramming when the MSE bit of the COMMAND register is not enabled at the time of changing BAR registers. See: cloud-hypervisor#7027 (comment) Signed-off-by: Bo Chen <[email protected]>
Use the right bar index and bar address maintained internally by the VMM when logging BAR reprogramming. Signed-off-by: Bo Chen <[email protected]>
likebreath
force-pushed
the
0509/refactor_detect_bar_reprog
branch
from
f808864 to
c1d1349
Compare
Member
Author
|
@rbradford Can you please take a look at this one? While we are working on a better solution to #7063, we can land this one first which is a pre-requisite anyway. |
rbradford
approved these changes
May 14, 2025
Merged
via the queue into
cloud-hypervisor:main
with commit May 15, 2025
59f98a2
38 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A BAR reprogramming of a PCI device will only happen when the (guest)
kernel write to its PCI config space, e.g. the detection of bar
reprogramming (
detect_bar_repgraomming()) can be embedded to the PCIconfig space write (
write_config_register()). It simplifies APIsexposed by the
struct PciConfigurationandtrait PciDevice. It alsoprepares for easier handling of pending bar reprogramming when the MSE
bit of the COMMAND register is not enabled at the time of changing BAR
registers.
See: #7027 (comment)